Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uint64_t with gazebo-entity user dataa #1451

Merged
merged 3 commits into from
May 4, 2022
Merged

Use uint64_t with gazebo-entity user dataa #1451

merged 3 commits into from
May 4, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 19, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Related with #1378

Summary

Use uint64_t with gazebo-entity user data

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Apr 19, 2022
@ahcorde
Remove todo
d34495a 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde mentioned this pull request Apr 19, 2022
Open
4 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 19, 2022
iche033
iche033 reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to add uint64_t to the Variant type in ign-rendering: https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering6/include/ignition/rendering/Node.hh#L45-L47

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 19, 2022

it's already on main https://github.com/ignitionrobotics/ign-rendering/blob/main/include/ignition/rendering/Node.hh#L45-L47

@ahcorde ahcorde requested a review from iche033 April 19, 2022 22:07
@iche033
Copy link
Contributor

iche033 commented Apr 19, 2022

oh yeah missed that.

changes look good. Not sure what's wrong with the ubuntu build. Just retriggered it.

@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1451 (94e8eff) into main (e399431) will not change coverage.
The diff coverage is n/a.

❗ Current head 94e8eff differs from pull request most recent head e41215e. Consider uploading reports for the commit e41215e to get more accurate results

@@           Coverage Diff           @@
##             main    #1451   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files          44       44           
  Lines        2356     2356           
=======================================
  Hits          825      825           
  Misses       1531     1531

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7063d41...e41215e. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 20, 2022

@osrf-jenkins retest this please

@j-rivero
Copy link
Contributor

j-rivero commented May 2, 2022

Seems like there are problems with nightly installation on Ubuntu, re-trigger the job to check if it is fixed or we need an intervention.

@ahcorde ahcorde merged commit 9370793 into main May 4, 2022
@ahcorde ahcorde deleted the ahcorde/7/gazbeo-entity branch May 4, 2022 18:55
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees

@ahcorde ahcorde

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @iche033 @j-rivero